<GitHub157>
[jruby] trejkaz closed issue #2404: File.mtime and friends return a date incorrect by an hour if created half a year ago https://git.io/mObLSw
<GitHub91>
[jruby] nateberkopec opened issue #4634: ENV.replace not working as expected https://git.io/vHlQA
cschneid_ has joined #jruby
<cschneid_>
I have a gem that uses a C extensions for a small bit of it - its easy to stub out in plain ruby - is there a way to tell JRuby's gem install that its an optional extra, and that the library works ok w/o it?
<cschneid_>
looks like other libs have a separate breakout library that users can optionally install, but that's not the best user experience
<GitHub94>
[jruby] muga opened pull request #4635: [WIP] Implement RubyDateParser in Java (master...implement_rubydateparser_in_java) https://git.io/vHl5V
shellac has quit [Quit: Computer has gone to sleep.]
hobodave has quit [Quit: Computer has gone to sleep.]
donV has quit [Quit: donV]
hobodave has joined #jruby
nirvdrum has quit [Ping timeout: 268 seconds]
<chrisseaton>
cschneid_: I think that is indeed how it's usually done. I think it's a pretty nice user experience - it's clear when you're using it and when you don't need it you can avoid it totally.
<cschneid_>
@chrisseaton I'm from scoutapp.com - doing ruby monitoring. So trying to keep the install as easy as possible is pretty important. I was thinking I'd reverse it - the `scout_apm` gem has C ext stuff, and requires a no-C `scout_apm_base` gem. Then jruby & no-c-compiler situations can use that base one....
<chrisseaton>
That seems good to me
<matthewd>
cschneid_: The only danger there is if other gems start depending on the "wrong" one. We have that problem in Rails.
nirvdrum has joined #jruby
<cschneid_>
matthewd: since it's the agent for a paid product, that seems unlikely that anybody would list us as a dependency. But yeah, that's the gotcha
<matthewd>
Yeah, agree it seems unlikely to be a problem in this case
<cschneid_>
Just a lot of rejiggering of all my code bases :)
<matthewd>
cschneid_: I think you should also be able to publish a scout_apm gem specifically for the java platform that does a straight pass-through to the _base
<cschneid_>
matthewd: ah perhaps - I don't know much about per-platform gems.
<cschneid_>
Is that a flag you can set "this is for jruby", "this is for mri" as part of the gem spec?
<matthewd>
So special cases like MRI-but-no-C-compiler can use it directly, but happy-path on jruby would just work
<matthewd>
Yeah, AFAIK you just set spec.platform = 'java' (or something like that?)
<cschneid_>
thanks for helping me think this through :)
lance|afk is now known as lanceball
hobodave has quit [Remote host closed the connection]
hobodave has joined #jruby
shellac has joined #jruby
subbu is now known as subbu|lunch
shellac has quit [Quit: Computer has gone to sleep.]
hobodave has quit [Quit: Computer has gone to sleep.]
drbobbeaty has quit [Read error: Connection reset by peer]
drbobbeaty has joined #jruby
shellac has joined #jruby
camlow325 has joined #jruby
prasunanand has quit [Ping timeout: 272 seconds]
hobodave has joined #jruby
camlow325 has quit [Quit: WeeChat 1.5]
camlow325 has joined #jruby
hobodave has quit [Quit: Computer has gone to sleep.]