Liothen has quit [Ping timeout: 246 seconds]
Liothen has joined #jruby
Liothen has quit [Max SendQ exceeded]
Liothen has joined #jruby
ur5us has joined #jruby
ur5us has quit [Remote host closed the connection]
ur5us has joined #jruby
ur5us has quit [Ping timeout: 260 seconds]
Antiarc has joined #jruby
ur5us has joined #jruby
ur5us has quit [Ping timeout: 260 seconds]
ur5us has joined #jruby
ur5us has quit [Ping timeout: 260 seconds]
travis-ci has joined #jruby
travis-ci has left #jruby [#jruby]
dopplergange has quit [Ping timeout: 256 seconds]
xardion has quit [Remote host closed the connection]
xardion has joined #jruby
<
lopex>
headius[m]: how should I name that enum, CodeRange is already taken and public
<
lopex>
maybe I'll leave it CodeRangeEntry
<
headius[m]>
CodeRangeType maybe?
<
headius[m]>
Entry is fine too
<
lopex>
headius[m]: i'll commit to master since it wont break anything for now
<
lopex>
headius[m]: that's a lot of enum classes though
<
lopex>
then there's another question
<
lopex>
where we should put that in api ?
<
headius[m]>
It's only one enum class
<
headius[m]>
Well I guess a method like isCType
<
lopex>
oh right, wrt enums
<
lopex>
but it should be a static field on unicode encoding then ?
<
lopex>
since it doesnt depend on unicode encoding type
<
lopex>
isInRange or something ?
<
lopex>
hmm UnicodeProperties.CodeRangeEntry.TITLECASELETTER
<
lopex>
UnicodeProperties is public, so we cant remove that
<
lopex>
headius[m]: it's not used though in joni and in jruby
<
lopex>
I'd happily rename UnicodeProperties to UnicodeCodeRange and make it a bit shallower
<
lopex>
headius[m]: ?
<
lopex>
UnicodeProperties is just a holder for that table
<
headius[m]>
Sounds good to me, I felt weird about that too
<
lopex>
headius[m]: UnicodeEncoding.isInCodeRange(UnicodeCodeRange.TITLECASELETTER, 498) ?
<
lopex>
or, actually move that to UnicodeCodeRAnge ?
<
lopex>
headius[m]: UnicodeCodeRange.TITLECASELETTER.contains(498) ?
<
lopex>
it's the best as it can get
travis-ci has joined #jruby
travis-ci has left #jruby [#jruby]
<
lopex>
this will simplify things in some places too
<
lopex>
there are some lookups there
<
lopex>
like grapheme clusters
dopplergange has joined #jruby
dopplergange has quit [Read error: Connection reset by peer]
dopplergange has joined #jruby
dopplerg- has joined #jruby
dopplergange has quit [Ping timeout: 265 seconds]
ur5us has joined #jruby
ur5us has quit [Ping timeout: 260 seconds]