<daveg_lookout[m]>
good morning! we're running with monkeypatched Monitor in staging now, running some perf tests later today, and will get it to prod tomorrow. Thanks again for the fast debugging and fix!
<headius[m]>
Thank you for the updated testing! This is a pretty big bug in the monitor library so it's great that we have found it
<headius[m]>
daveg_lookout: were you ever able to pull a heap dump>
<headius[m]>
it basically tries to unify some argument and executable handling between popen and system (JDK logic for Windows) to fix https://github.com/jruby/jruby/issues/6516
<headius[m]>
I was going to try to get Windows using more of the native IO and process stuff but ran into the big blocker: jnr-enxio only supports epoll and kqueue, and Windows only has select (with its macro grossness) or WaitForSingleObject
subbu is now known as subbu|lunch
<headius[m]>
I thought I was doing it right but it tried to install the bindex C lib and crapped out
<headius[m]>
everything worked up to that point though
<enebo[m]>
ok I will see if that works at least
<headius[m]>
I haven't looked at your script recently
<enebo[m]>
Rails 5.2 I think is what I test on also because of the sassc stuff
<enebo[m]>
I think it is the same script but I use a different version of Rails
<headius[m]>
yeah I forced it to 6.0.0 to get the ruby sass
<headius[m]>
but I guess bindex is an issue too
<enebo[m]>
I think bindex was fixes after 6.0.0
<headius[m]>
oh I see now it installed rails 6.0.0 but when it generates app it does not stick to that version
<headius[m]>
so rails new ended up installing 6.0.3.4
ur5us__ has joined #jruby
<headius[m]>
enebo: I did that fix against 9.2.15 but we could make it 9.3 if it seems too risky
<enebo[m]>
headius: if there is no detected problems we can consider what other things may raise that message
<headius[m]>
the message fix should be benign
<headius[m]>
the popen changes less so
subbu|lunch is now known as subbu
<daveg_lookout[m]>
headius: no, sorry :-( After about an hour I stopped paying attention, then forgot about it when we deployed new instances with the monkeypatched Monitor. That code is in production now. We'll probably increase traffic to those instances tomorrow
ur5us__ has quit [Ping timeout: 264 seconds]
ur5us has joined #jruby
<enebo[m]>
rails is fine and popen is working as well
subbu is now known as subbu|away
<headius[m]>
daveg_lookout: well no matter, we will see if it behaves better now
<headius[m]>
enebo: ok I will go ahead and merge that then