<edipofederle[m]>
Sorry to bother you guys, some advice on how to debug it locally? I've tried the travis commands locally works as expected.
ur5us has quit [Ping timeout: 258 seconds]
joast has quit [Quit: Leaving.]
sagax has quit [*.net *.split]
sagax has joined #jruby
ur5us has joined #jruby
michael_mbp has quit [Ping timeout: 265 seconds]
michael_mbp has joined #jruby
<headius[m]>
Ahh that makes it trickier
<headius[m]>
edipo.federle I believe Travis has a published Docker image that should simulate the same environment. You could start that up locally with debugging ports and
<RobertNicholas[m>
<enebo[m] "Robert Nicholas: https://github."> Yeah seeing your project was inspiration for me to actually get this working so thank you :) if you ever wanna collab / assist on this stuff and have spare time lemme know!
<RobertNicholas[m>
also spigot is the 'new' high performance bukkit, essentially the same as bukkit but better
HarrisKauffman[m has quit [Ping timeout: 245 seconds]
lopex[m] has quit [Ping timeout: 247 seconds]
MattPattersonGit has quit [Ping timeout: 247 seconds]
RobertNicholas[m has quit [Ping timeout: 245 seconds]
kalenp[m] has quit [Ping timeout: 245 seconds]
MarcinMielyskiGi has quit [Ping timeout: 246 seconds]
UweKuboschGitter has quit [Ping timeout: 245 seconds]
byteit101[m] has quit [Ping timeout: 258 seconds]
CharlesOliverNut has quit [Ping timeout: 258 seconds]
ChrisSeatonGitte has quit [Ping timeout: 258 seconds]
rdubya[m] has quit [Ping timeout: 258 seconds]
chrisseaton[m] has quit [Ping timeout: 245 seconds]
KarolBucekGitter has quit [Ping timeout: 245 seconds]
TimGitter[m]1 has quit [Ping timeout: 248 seconds]
FlorianDoubletGi has quit [Ping timeout: 248 seconds]
TimGitter[m] has quit [Ping timeout: 276 seconds]
ahorek[m] has quit [Ping timeout: 276 seconds]
OlleJonssonGitte has quit [Ping timeout: 276 seconds]
edipofederle[m] has quit [Ping timeout: 246 seconds]
JulesIvanicGitte has quit [Ping timeout: 246 seconds]
kai[m] has quit [Ping timeout: 258 seconds]
mrtommy[m] has quit [Ping timeout: 245 seconds]
BlaneDabneyGitte has quit [Ping timeout: 245 seconds]
rtyler1 has quit [Ping timeout: 245 seconds]
fzakaria has quit [Ping timeout: 245 seconds]
JesseChavezGitte has quit [Ping timeout: 245 seconds]
kares[m] has quit [Ping timeout: 245 seconds]
slonopotamus[m] has quit [Ping timeout: 250 seconds]
RomainManni-Buca has quit [Ping timeout: 245 seconds]
headius[m] has quit [Ping timeout: 245 seconds]
enebo[m] has quit [Ping timeout: 276 seconds]
liamwhiteGitter[ has quit [Ping timeout: 276 seconds]
XavierNoriaGitte has quit [Ping timeout: 276 seconds]
knu has quit [*.net *.split]
justinmcp has quit [*.net *.split]
Osho has quit [*.net *.split]
Caerus has quit [*.net *.split]
fidothe has quit [*.net *.split]
Iambchop has quit [*.net *.split]
subbu has quit [*.net *.split]
victori_ has quit [*.net *.split]
Sebb has quit [*.net *.split]
ebarrett has quit [*.net *.split]
Sebb has joined #jruby
Iambchop has joined #jruby
ebarrett has joined #jruby
victori_ has joined #jruby
subbu has joined #jruby
Caerus has joined #jruby
fidothe has joined #jruby
knu has joined #jruby
Osho has joined #jruby
justinmcp has joined #jruby
ur5us has quit [*.net *.split]
michael_mbp has quit [*.net *.split]
sagax has quit [*.net *.split]
OlleJonssonGitte has joined #jruby
sagax has joined #jruby
ur5us has joined #jruby
OlleJonssonGitte has joined #jruby
OlleJonssonGitte has quit [Changing host]
JesseChavezGitte has joined #jruby
satyanash has quit [*.net *.split]
RomainManni-Buca has joined #jruby
satyanash has joined #jruby
michael_mbp has joined #jruby
drbobbeaty has joined #jruby
ChrisSeatonGitte has joined #jruby
byteit101[m] has joined #jruby
TimGitter[m]1 has joined #jruby
rdubya[m] has joined #jruby
MattPattersonGit has joined #jruby
JulesIvanicGitte has joined #jruby
MarcinMielyskiGi has joined #jruby
edipofederle[m] has joined #jruby
lopex[m] has joined #jruby
CharlesOliverNut has joined #jruby
TimGitter[m]1 has quit [Ping timeout: 245 seconds]
edipofederle[m] has quit [Ping timeout: 250 seconds]
JulesIvanicGitte has quit [Ping timeout: 245 seconds]
MarcinMielyskiGi has quit [Ping timeout: 245 seconds]
OlleJonssonGitte has quit [Ping timeout: 245 seconds]
lopex[m] has quit [Ping timeout: 245 seconds]
rdubya[m] has quit [Ping timeout: 258 seconds]
MattPattersonGit has quit [Ping timeout: 258 seconds]
RomainManni-Buca has quit [Ping timeout: 250 seconds]
CharlesOliverNut has quit [Ping timeout: 250 seconds]
byteit101[m] has quit [Ping timeout: 245 seconds]
ChrisSeatonGitte has quit [Ping timeout: 245 seconds]
JesseChavezGitte has quit [Ping timeout: 245 seconds]
FlorianDoubletGi has joined #jruby
ur5us has quit [Ping timeout: 268 seconds]
subbu_ has joined #jruby
subbu has quit [Ping timeout: 246 seconds]
TimGitter[m] has joined #jruby
ahorek[m] has joined #jruby
liamwhiteGitter[ has joined #jruby
XavierNoriaGitte has joined #jruby
KarolBucekGitter has joined #jruby
chrisseaton[m] has joined #jruby
kai[m] has joined #jruby
kalenp[m] has joined #jruby
UweKuboschGitter has joined #jruby
RobertNicholas[m has joined #jruby
fzakaria has joined #jruby
HarrisKauffman[m has joined #jruby
BlaneDabneyGitte has joined #jruby
mrtommy[m] has joined #jruby
rtyler1 has joined #jruby
slonopotamus[m] has joined #jruby
headius[m] has joined #jruby
kares[m] has joined #jruby
enebo[m] has joined #jruby
TimGitter[m]1 has joined #jruby
MattPattersonGit has joined #jruby
edipofederle[m] has joined #jruby
rdubya[m] has joined #jruby
OlleJonssonGitte has joined #jruby
JulesIvanicGitte has joined #jruby
MarcinMielyskiGi has joined #jruby
lopex[m] has joined #jruby
RomainManni-Buca has joined #jruby
CharlesOliverNut has joined #jruby
ChrisSeatonGitte has joined #jruby
byteit101[m] has joined #jruby
JesseChavezGitte has joined #jruby
<enebo[m]>
Robert Nicholas: if you want to contribute to Purugin that would be great too. I will update it again for cave update and I know I am missing some materials and stuff
<headius[m]>
g'day
<enebo[m]>
byteit101: so do you think your feature work on your PR is ready? Looking at test failures none of it appears to be related to your work.
<headius[m]>
enebo: I will continue culling the 9.3 herd today... got a few PRs to clean up and land from my first pass through
<headius[m]>
there are a few of your issues or stuff related to parsing that I have not done anything with
<enebo[m]>
I need to feal with IRFor and IR persistence for sure
<enebo[m]>
since for loops are used by logstash and they must AOT something using them
<enebo[m]>
(not that knowing a single user uses something uncommon is the sole reason but whatevs...it is broken)
<headius[m]>
ah yhea
<headius[m]>
I did label and close that flip-flop thing so that was one
<headius[m]>
I have punted a few things but mostly been closing stuff that is done
<headius[m]>
or finishing stuff that was close
<enebo[m]>
copy executable /home/enebo/work/jruby/lib/ruby/gems/shared/bin/rake to /home/enebo/work/jruby/bin
<enebo[m]>
Errno::ENOENT: No such file or directory - /home/enebo/work/jruby/lib/ruby/gems/shared/bin/rake
<enebo[m]>
seeing it -Pbootstrap fixes this
<enebo[m]>
nope. So I am confused how come I hit this and a CI env will not
<headius[m]>
what is happening?
<headius[m]>
enebo: this is your local build?
<enebo[m]>
yeah I have no rake in shared/bin
<enebo[m]>
and it is not a git saved thing right?
<enebo[m]>
with that said this is not preventing me from working on this branch since I have rake installed and it is in bin already (and jruby.jar will be built before this)
_whitelogger has joined #jruby
<headius[m]>
it should be installed during build but there is still an issue where if it looks like it was already installed it won't copy stuff
<headius[m]>
I don't think that should cause ENOENT though
<headius[m]>
it just wouldn't install
<enebo[m]>
yeah so it is in section 'install gems unless already installed'
<enebo[m]>
so I guess it assumes rake is installed then assumes it has been copied into shared/bin
<enebo[m]>
but i am guessing I just did a gem install rake
<headius[m]>
it should not try to copy it if it did not install it
<enebo[m]>
so it thinks rake is there but not installed the way we want it
<enebo[m]>
I will completely nuke all traces of rake and build again
<enebo[m]>
this would make sense that a new co would not see this but I maybe somehow gapped over this changeset so I have never been in a good state
<headius[m]>
so the failing tests fail because it never ends the stream, which would force snakeyaml to flush the pending events
<headius[m]>
adding @stream.finish allows it to work properly
<headius[m]>
but it is a change in behavior for snakeyaml to defer emitting these events
<headius[m]>
I think I will proceed for now by excluding the tests and opening an issue with psych and snakeyaml
<headius[m]>
it does not appear to affect any other test runs
<byteit101[m]>
> byteit101: so do you think your feature work on your PR is ready? Looking at test failures none of it appears to be related to your work.
<byteit101[m]>
Mostly, however I do have some todo's scattered around that I wasn't sure about, and a general review pass would be nice to ensure I didn't screw things up, particularly about kares's december PR
<byteit101[m]>
Only thing changed since march is the method api has now been doc'd
<byteit101[m]>
(sorry headius, meant enebo)
<enebo[m]>
ok I just looked at TODOs and I think one aspect of this feature is that we will not JIT these split consutrctors
<enebo[m]>
Even the TODO on caching the search is sort of an outcome of this because if we JIT'd what this is doing in Java we would make a calsite cache for it
<enebo[m]>
So I think we can ignore all the TODOs
<enebo[m]>
Even the call protocol TODO is based on notion this code would make it past the startup interp and it doesn't
<enebo[m]>
byteit101: we talked about this earlier today and once landed I will do a single pass over the code and do mild style tweaks as needed
<enebo[m]>
you can look at those changes to see what things we tend to do stylistically for next time
<byteit101[m]>
Sounds good
<enebo[m]>
I will add that this was a first stake in the ground here. We know it will only use startup interp for these constructors but we can improve on that in a later PR
<enebo[m]>
So barring something coming up I will merge this today...congrats! This was a big feature. We appreciate you sticking with this PR
<headius[m]>
psych 3.3.2 update should land shortly... I excluded the few failures since it is unclear whether they are valid behavior differences in SnakeYAML or not