<GitHub176> [jruby] headius pushed 3 new commits to jruby-9.1: https://git.io/vNtYh
<GitHub176> jruby/jruby-9.1 c5d3cd2 Charles Oliver Nutter: Revert "Reduce JVM signal usage during MRI suite to help signal tests."...
<GitHub176> jruby/jruby-9.1 d213ade Charles Oliver Nutter: Exclude test that hooks SIGTRAP used by JVM.
<GitHub176> jruby/jruby-9.1 f5539dc Charles Oliver Nutter: Merge branch 'null_toplevel_frame_name' into jruby-9.1
<headius> that better do it
<headius> ttyl folks
<GitHub49> [jruby] headius deleted null_toplevel_frame_name at 6908774: https://git.io/vNtOf
cremes has quit [Quit: cremes]
<chrisseaton> headius: have you read about 'exceptionalisation' in the JVM? http://delivery.acm.org/10.1145/3050000/3046681/a5-yang.pdf
<chrisseaton> (not sure if you have ACM DL access)
<chrisseaton> "the performance of Ruby-on-JVM shows an improvement by as much as 60% and by 6% on average"
lopex has quit [Quit: Connection closed for inactivity]
<pcarlisle> [un
<pcarlisle> oops ignore
pcarlisle has quit [Ping timeout: 240 seconds]
cremes has joined #jruby
rdubya has quit [Read error: Connection reset by peer]
rdubya1 has joined #jruby
chrisseaton has quit [Ping timeout: 272 seconds]
chrisseaton has joined #jruby
cremes has quit [Quit: cremes]
prasun has joined #jruby
bga57 has quit [Ping timeout: 248 seconds]
rrutkowski has joined #jruby
bga57 has joined #jruby
rrutkowski has quit [Ping timeout: 256 seconds]
rrutkowski has joined #jruby
rrutkowski has quit [Client Quit]
rrutkowski has joined #jruby
rrutkowski has quit [Ping timeout: 240 seconds]
e_dub has joined #jruby
e_dub has quit [Client Quit]
<GitHub5> [jruby] headius opened issue #4960: JVM finalizer threads get adopted into JRuby thread list https://git.io/vNtVa
e_dub has joined #jruby
e_dub has quit [Client Quit]
e_dub has joined #jruby
e_dub has quit [Client Quit]
e_dub has joined #jruby
e_dub has quit [Client Quit]
e_dub has joined #jruby
e_dub has quit [Client Quit]
e_dub has joined #jruby
e_dub has quit [Client Quit]
e_dub has joined #jruby
e_dub has quit [Client Quit]
e_dub has joined #jruby
e_dub has quit [Client Quit]
<GitHub161> [jruby] headius pushed 1 new commit to jruby-9.1: https://git.io/vNtVy
<GitHub161> jruby/jruby-9.1 2148feb Charles Oliver Nutter: Exclude MRI test that checks thread lists. See #4960...
e_dub has joined #jruby
e_dub has quit [Client Quit]
e_dub has joined #jruby
e_dub has quit [Client Quit]
e_dub has joined #jruby
e_dub has quit [Client Quit]
e_dub has joined #jruby
e_dub has quit [Client Quit]
e_dub has joined #jruby
e_dub has quit [Client Quit]
e_dub has joined #jruby
e_dub has quit [Client Quit]
e_dub has joined #jruby
e_dub has quit [Client Quit]
e_dub has joined #jruby
e_dub has quit [Client Quit]
e_dub has joined #jruby
e_dub has quit [Client Quit]
e_dub has joined #jruby
e_dub has quit [Client Quit]
e_dub has joined #jruby
e_dub has quit [Client Quit]
e_dub has joined #jruby
e_dub has quit [Client Quit]
e_dub has joined #jruby
e_dub has quit [Client Quit]
e_dub has joined #jruby
e_dub has quit [Client Quit]
e_dub has joined #jruby
e_dub has quit [Client Quit]
e_dub has joined #jruby
e_dub has quit [Client Quit]
e_dub has joined #jruby
e_dub has quit [Client Quit]
e_dub has joined #jruby
e_dub has quit [Client Quit]
e_dub has joined #jruby
e_dub has quit [Client Quit]
e_dub has joined #jruby
e_dub has quit [Client Quit]
e_dub has joined #jruby
e_dub has quit [Client Quit]
e_dub has joined #jruby
e_dub has quit [Client Quit]
e_dub has joined #jruby
e_dub has quit [Client Quit]
e_dub has joined #jruby
e_dub has quit [Client Quit]
e_dub has joined #jruby
e_dub has quit [Client Quit]
e_dub has joined #jruby
e_dub has quit [Client Quit]
e_dub has joined #jruby
e_dub has quit [Client Quit]
olle has joined #jruby
claudiuinberlin has joined #jruby
olle has quit [Quit: olle]
lopex has joined #jruby
vtunka has joined #jruby
olle has joined #jruby
olle has quit [Quit: olle]
olle has joined #jruby
<GitHub166> [jruby] kares closed pull request #4932: Fix a typo to match documents (master...arg_typo) https://git.io/vbpbJ
<GitHub104> [jruby] kares pushed 1 new commit to master: https://git.io/vNtXj
<GitHub104> jruby/master 1f53471 Yuichiro Kaneko: Fix a typo to match documents (#4932)
<ChrisBr> kares: just saw your comment on #4957 but I'm not sure if I understand :) What should I use instead of this.hash?
vtunka has quit [Quit: vtunka]
drbobbeaty has joined #jruby
vtunka has joined #jruby
drbobbeaty has quit [Quit: Textual IRC Client: www.textualapp.com]
dave__ has joined #jruby
dave__ has quit [Remote host closed the connection]
drbobbeaty has joined #jruby
shellac has quit [Remote host closed the connection]
shellac has joined #jruby
drbobbeaty has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…]
prasun has quit [Remote host closed the connection]
drbobbeaty has joined #jruby
bbrowning_away is now known as bbrowning
cremes has joined #jruby
<GitHub11> [jruby] headius created aborting_is_alive (+1 new commit): https://git.io/vNqUd
<GitHub11> jruby/aborting_is_alive 048632e Charles Oliver Nutter: Treat "aborting" status as alive, as in MRI....
vtunka has quit [Quit: vtunka]
vtunka has joined #jruby
<GitHub9> [jruby] headius deleted aborting_is_alive at 048632e: https://git.io/vNqtP
rdubya1 has quit [Quit: Leaving.]
<GitHub88> [jruby] headius pushed 1 new commit to jruby-9.1: https://git.io/vNqml
<GitHub88> jruby/jruby-9.1 048632e Charles Oliver Nutter: Treat "aborting" status as alive, as in MRI....
rdubya has joined #jruby
<headius> morning!
<nirvdrum7160> Howdy.
<nirvdrum7160> Ugh. Looks like I need to get my nick fixed.
<travis-ci> jruby/jruby (aborting_is_alive:048632e by Charles Oliver Nutter): The build passed. (https://travis-ci.org/jruby/jruby/builds/326821648)
<headius> the end is nigh
<headius> we had a green build
<headius> nirvdrum7160: greetings
<nirvdrum7160> brb
nirvdrum7160 has quit [Remote host closed the connection]
nirvdrum7160 has joined #jruby
nirvdrum7160 is now known as nirvdrum
nirvdrum has quit [Changing host]
nirvdrum has joined #jruby
<nirvdrum> There we go.
<nirvdrum> headius: It's a small win, but I noticed last night that StringSupport.isUnicode can either be removed or simplified. Encoding has an #isUnicode method on it. And since you fixed dummy encodings, UTF-7 is backed by ASCIIEncoding (or maybe USASCIIEncoding -- I can't recall which), so it always returns false for #isUnicode.
<headius> seems reasonable
<headius> looks like we only use it in String#inspect and when building regexp
<headius> nice to know we can nuke it :-)
<GitHub7> [jruby] headius pushed 1 new commit to jruby-9.1: https://git.io/vNqYF
<GitHub7> jruby/jruby-9.1 c2d72a3 Charles Oliver Nutter: Remove unnecessary isUnicode check; Encoding.isUnicode is accurate
<nirvdrum> I was looking through StringSupport again for old code. This weird method checking for UTF-7 caught my eye :-)
<ChrisBr> headius: thanks for the hints in https://github.com/jruby/jruby/issues/4958, I think I understand the problem now! Will try to provide a fix tonight
<travis-ci> jruby/jruby (jruby-9.1:048632e by Charles Oliver Nutter): The build was fixed. (https://travis-ci.org/jruby/jruby/builds/326843215)
<headius> ChrisBr: cool, yeah I almost had it but I didn't have time to audit that I was cleaning up the links properly
<headius> it's not a very good rehash function...it doesn't even resize the bucket array
shellac has quit [Quit: Leaving]
olle has quit [Quit: olle]
vtunka has quit [Quit: vtunka]
cremes has quit [Quit: cremes]
cremes has joined #jruby
dave__ has joined #jruby
dave___ has joined #jruby
dave__ has quit [Ping timeout: 264 seconds]
<headius> oh I didn't even notice green 9.1 build
<headius> finally
e_dub has joined #jruby
e_dub has quit [Client Quit]
claudiuinberlin has quit [Quit: Textual IRC Client: www.textualapp.com]
<nirvdrum> headius: Also, unless I'm really missing something, EncodingService#charsetForEncoding can just delegate to Encoding#getCharset.
<nirvdrum> I'm a bit unclear on the ISO_8859_16 case. But that should be handled in jcodings if it isn't already.
<headius> 16 doesn't exist in JDK but I added it to jcodings
<headius> so special case code shouldn't be necessary now
<GitHub29> [jruby] headius pushed 1 new commit to master: https://git.io/vNq6i
<GitHub29> jruby/master e3bac23 Charles Oliver Nutter: Merge branch 'jruby-9.1'
<headius> ok, now master.
<nirvdrum> headius: Confirming that SPI thing works well. Nice!
<nirvdrum> As jcodings has gotten smarter, it looks like some of this support code can be simplified or eliminated.
<headius> yeah I clean up things whenever I have to go back in there
<headius> as much as is reasonable
headius_ has joined #jruby
headius_ has quit [Client Quit]
headius_ has joined #jruby
ddadacha has joined #jruby
<headius_> yay
headius has quit [Quit: ZNC - http://znc.in]
headius_ is now known as headius
<headius> woot
<headius> moved my bounder to an ARM cloud
<headius> bouncer
<headius> huh, only test:mri failed after merge, that's great
<GitHub131> [jruby] headius pushed 1 new commit to master: https://git.io/vNqDY
<GitHub131> jruby/master f507f6c Charles Oliver Nutter: Merge branch 'jruby-9.1'
<GitHub134> [jruby] headius fast-forwarded jruby-9.1 from c2d72a3 to e55ba79: https://git.io/vNqDs
subbu is now known as subbu|away
claudiuinberlin has joined #jruby
mistergibson has joined #jruby
<GitHub8> [jruby] headius pushed 2 new commits to master: https://git.io/vNqh5
<GitHub8> jruby/master c4e7e5b Charles Oliver Nutter: Temporarily exclude tests failing due to rescue breakage. #4895
<GitHub8> jruby/master e390180 Charles Oliver Nutter: Reorder close cleanup before thread wakeups....
subbu|away is now known as subbu
<chrisseaton> headius: did you see that exceptionalise thing?
<headius> I did not
<chrisseaton> https://dl.acm.org/citation.cfm?id=3046681 can you see that?
<headius> chrisseaton: I can see the page but would have to go through another route to download it...sounds interesting!
<chrisseaton> Talks about JRuby
<headius> nice...I'll try downloading through Red HAt
<chrisseaton> "Figure 14 shows that exceptionization improves the Ruby performance by 60% at maximum and by 6% on average."
<headius> well, that sounds promising
<enebo> indeed
<enebo> premise is pretty neat
<enebo> Assuming the abstract explanation basically predicts uncommon paths and makes those generate exceptions when they should have been taken
<enebo> I wondered about the idea of tracing in conjunction with the inliner which would deopt if it did not follow a trace
<enebo> I suspect that it just how a tracing jit might work thoug?
<enebo> " Antonio Cangiano. 2016. Ruby Benchmark Suite. Retrieved May 13, 2016 from https://github.com/acangiano/ruby-benchmark-suite. "
<enebo> so they maybe used this as their bench
<travis-ci> jruby/jruby (jruby-9.1:e55ba79 by Charles Oliver Nutter): The build was fixed. (https://travis-ci.org/jruby/jruby/builds/326938981)
dave___ has quit [Read error: No route to host]
<chrisseaton> It's how any uncommon trap system works - it just sets a higher threshold I think, and lets you handle it manually when you catch
<chrisseaton> Truffle does this as well of course
<enebo> chrisseaton: yeah I image all things basically fail something and fall back to something on anything speculative
<enebo> It is almost funny how many things are described by that :)
<enebo> nonetheless the notion of replacing one set of instrs in our runtime with another whether inlining or stripping out extra block semantics needs to be more decoupled from the inlining code
<ddadacha> headius: ended up hacking a build together for jruby-rack btw...figured out my problem from yesterday
<headius> oh great!
<ddadacha> it was a bang head on wall kind of moment when I saw the error..
<ddadacha> secret token was not set in my staging env :'(
<ddadacha> I'm assuming that the response did not include the message because that type of error isn't rendered by rails in staging/prod envs
<ChrisBr> headius: when I want to add a new test for, where would I add it? Asking for https://github.com/jruby/jruby/issues/4958
<ChrisBr> Or can I just extend e.g. mri tests?
drbobbeaty has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…]
<GitHub128> [jruby] ChrisBr opened pull request #4961: Fix Hash#rehash method for duplicate keys (master...bug/rehash) https://git.io/vNmLN
<headius> ChrisBr: spec/ruby is best
<ChrisBr> already done ^^
<headius> if it's a Ruby feature, spec/ruby ... specific to JRuby, test/jruby or spec/java_integration or spec/compiler or something
<ChrisBr> the mri tests we just cherry pick from mri and we do not change, right?
<headius> ChrisBr: that's right
<headius> I update them periodically, usually when we move up a compat level
<ChrisBr> ok
claudiuinberlin has quit [Quit: Textual IRC Client: www.textualapp.com]
<GitHub98> [jruby] headius pushed 1 new commit to master: https://git.io/vNmO3
<GitHub98> jruby/master 9f46710 Charles Oliver Nutter: Avoid load errors on boot....
<ddadacha> headius: made the issue and a quick PR as well https://github.com/jruby/jruby-rack/pull/214
<ddadacha> thanks again for the help!
<headius> ah ha, I saw that line but wasn't sure
<headius> I concur!
bbrowning is now known as bbrowning_away
<ddadacha> I was fidgeting with adding the stack trace but didn't find a clean way apart from cping something like this https://github.com/jruby/jruby-rack/blob/1.1-stable/src/main/java/org/jruby/rack/RackException.java#L50
<headius> hmm
<ddadacha> may circle back to do that
<headius> oh there's a context.log that takes an exception
<headius> use that
<headius> log(java.lang.String message, java.lang.Throwable throwable)
<ddadacha> I used context.log but it only gave the message
<ddadacha> ohh pass the exception in ass well
<ddadacha> as*
<GitHub7> [jruby] enebo pushed 1 new commit to jruby-9.1: https://git.io/vNmsd
<GitHub7> jruby/jruby-9.1 2a26055 Thomas E. Enebo: Fixes #4895. Regression in 9.1.15.0 with some ensure blocks being executed...
<headius> woot
<headius> ddadacha: yeah, servlet engine can format it appropriately then
<GitHub164> [jruby] enebo pushed 1 new commit to master: https://git.io/vNmGf
<GitHub164> jruby/master 28d18cf Thomas E. Enebo: Merge branch 'jruby-9.1'
<GitHub158> [jruby] enebo closed issue #4895: Regression in 9.1.15.0 with some ensure blocks being executed twice https://git.io/vbacu
<ddadacha> it would probably be good to have the other log do the same thing then https://github.com/jruby/jruby-rack/blob/1.1.21/src/main/java/org/jruby/rack/AbstractRackDispatcher.java#L49
<headius> I agree
<headius> dunno if there was a reason not to
<headius> probably not
<ddadacha> yeah must have just slipped by, probably the same thing for my other change too
<ddadacha> I just added it for both
<headius> cool
<ddadacha> thanks for the help again, much appreciated
<GitHub85> [jruby] enebo pushed 1 new commit to master: https://git.io/vNmnG
<GitHub85> jruby/master 0d7d15e Thomas E. Enebo: Remove tests which work because of fix for #4895
<GitHub8> [jruby] yui-knk closed pull request #4945: Fix warnings (master...fix_warning) https://git.io/vNTGu
ddadacha has left #jruby ["done for today!"]
<travis-ci> jruby/jruby (jruby-9.1:2a26055 by Thomas E. Enebo): The build passed. (https://travis-ci.org/jruby/jruby/builds/327027916)
burnninator has joined #jruby
<burnninator> Is anyone aware of a known issue where calling respond_to? with a protected method always returns false?
<burnninator> Using latest jruby 9.1.15.0