<GitHub194>
[jruby] enebo pushed 3 new commits to ruby-2.5: https://git.io/vNsel
<GitHub194>
jruby/ruby-2.5 b024241 Miguel Landaeta: Add MRI tests for Hash#transform_keys and Hash#transform_keys!
<GitHub194>
jruby/ruby-2.5 5d431ce Miguel Landaeta: Implement Hash#transform_keys and Hash#transform_keys!...
<GitHub194>
jruby/ruby-2.5 527b036 Thomas E Enebo: Merge pull request #4966 from nomadium/implement-hash-transform-keys...
<headius>
woot
<headius>
folks piling on 2.5 stuff
<headius>
enebo: kares updated the 2.5 checklist, we should try to keep it up to date now
<headius>
I'm going to focus on getting windows Kernel.spawn working today
<enebo>
headius: yeah
<enebo>
oh I added a 'features' label to issues
<enebo>
so I put 2.4 and 2.5 issue as a feature
<enebo>
I added an issue on bytelist work as a feature
<enebo>
basically high-level bigger features which people may want to track can be labelled this way
<enebo>
So when someone asks what is coming or what we plan on doing we can point to features
<lopex>
headius: I think we can bump jcodings so we can begin putting that case mapping in the core
<lopex>
that absent operator is also mostly done
rdubya has quit [Quit: Leaving.]
subbu is now known as subbu|lunch
<headius>
enebo: ahh nice
<headius>
lopex: full release then?
<lopex>
headius: yeah, that will require releasing joni too since both went an overhaul
<lopex>
but before I'd run mri tests for regressions
<lopex>
er, underwent
<headius>
ok sure, I'll push a branch with snapshots and we'll see how it goes
<headius>
any risk to 9.1?
<lopex>
hm
<headius>
we are missing features in there that you have added, but 9.1 may be done soon too and it's stable
<lopex>
lots of joni is basically rewritten
<lopex>
so I dont know
<headius>
well I'll do it against master for now then
<headius>
we'll see how it looks
<enebo>
seems we should consider these major versions?
<lopex>
jcodings has big changes too
<enebo>
odds if we put joni/jcodings on maint branches for 9.1 that we will likely never have to release
<headius>
enebo: that's probably a good idea
<enebo>
if lopex says he doesn't know off the top of his head it will not be safe :)
<lopex>
actually the only thing jcodings misses now is caseMap for the rest of encodings apart from singlebyte and unicode
<headius>
ha
<lopex>
enebo: I'm not confident in joni test coverage
<enebo>
lopex: you seem to remember your impl details so well the fact that you paused is enough for me
<lopex>
enebo: though jacoco is full for the most complex code
<enebo>
lopex: we do not gain very much by keeping it a point release
<lopex>
enebo: that's because lots of is rewritten
<lopex>
yeah
<lopex>
anyways, all new features are covered by onigmo tets
<lopex>
tests
<enebo>
worst case it could lead to releasing two versions of each if there is some weird vuln or something that is actually broken; but odds of that are small enough we may as well just push forward...it does have major new features too
<enebo>
lopex: and you don't even have to make the maint. branch until we discover something is broken or needs a maint release
<enebo>
lopex: so I think we should just bump to majors on both in pom and be done with it for now
<lopex>
enebo: but no regressions, so anything comes up against jruby master will be a good start
claudiuinberlin has joined #jruby
<lopex>
enebo: there's also small chance new unicode data break 2.4 compat
<enebo>
lopex: so you want to try using the same release for 9.1 master and ruby-2.5 and see if it works?
<enebo>
I definitely do not want it on jruby-9.1
<enebo>
but master is more iffy if it works it is ok if it doesn't then what?
<lopex>
then we'll worry :P
mistergibson has quit [Quit: Leaving]
<enebo>
we sort of need to know that before we put out a joni + jcodings release don't we?
<lopex>
enebo: that's why headius said he's going to run that against master
<enebo>
lopex: but how likely will that actually tell us if there is an issue?
<enebo>
lopex: I mean if some update changed case detection we would only see some data difference based on trying to use that same data
<enebo>
lopex: or is all the data the same?
<lopex>
enebo: casemap is not used in jruby code yet
<enebo>
well I was just using an example
<lopex>
transcoder data is the same
<lopex>
the only thing changed is code ranges and fold tables (wrt data)
<lopex>
enebo: anyways, I just wanted to know for now
subbu|lunch is now known as subbu
<enebo>
lopex: ok well you probably are best person to know I am just bringing it up in fear of us rolling with it and then 3 months someone is reporting an issue with some small difference between us and 2.4
<enebo>
lopex: I guess fwiw if that is an issue their stuff won't work on 2.5 then
<enebo>
which perhaps makes that concern a little less concerning
<lopex>
so let's wait for another release
<lopex>
for now I just wnated to know what regresses
<lopex>
does CI run any rails tests ?
rrutkowski has joined #jruby
mistergibson has joined #jruby
rrutkowski has quit [Quit: rrutkowski]
rrutkowski has joined #jruby
<headius>
lopex: not currently no
<headius>
eneboCI does
<headius>
lopex: snaps updated, pushed branch to test with them
<GitHub187>
[jruby] headius created new_joni_jcodings (+1 new commit): https://git.io/vNssO
<GitHub187>
jruby/new_joni_jcodings 750d42f Charles Oliver Nutter: Test latest joni and jcodings snaps.
<enebo>
at first I thought that was a type
<lopex>
so where should I put core changes like casemapping ?
<lopex>
headius: thx
<headius>
lopex: where? like what JRuby branch?
<lopex>
yeah
<headius>
master is fine if so
<headius>
9.2 will eventually come out with 2.4 support, and since that stuff was in 2.3....
<headius>
it's fine
rrutkowski has quit [Quit: rrutkowski]
rrutkowski has joined #jruby
snowp has joined #jruby
rdubya has joined #jruby
<lopex>
whoops, errors
rrutkowski has quit [Client Quit]
rrutkowski has joined #jruby
provokeme has joined #jruby
<GitHub133>
[jruby] enebo pushed 5 new commits to bytelist_love: https://git.io/vNsnr
<GitHub133>
jruby/bytelist_love f8e7e74 Thomas E. Enebo: Merge branch 'master' into bytelist_love
<GitHub133>
jruby/bytelist_love c920b1f Thomas E. Enebo: Whoops did not realize this did not get added to last merge commit.
<GitHub133>
jruby/bytelist_love 6e25884 Thomas E. Enebo: Document what nodes are possible to undef.
<GitHub13>
[jruby] headius pushed 1 new commit to new_joni_jcodings: https://git.io/vNsn7
<GitHub13>
jruby/new_joni_jcodings 75d0b1b Charles Oliver Nutter: Commit pom.xml from joni/jcodings update.
<GitHub164>
[jruby] BanzaiMan opened issue #4967: [Chore] Remove superfluous archives from S3 bucket https://git.io/vNsW8
<lopex>
headius: pushed with that failing thing turned off
drbobbeaty has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…]