xardion has quit [Remote host closed the connection]
xardion has joined #jruby
akp has joined #jruby
Puffball has joined #jruby
kares has quit [Ping timeout: 256 seconds]
akp has quit [Remote host closed the connection]
enebo has quit [Ping timeout: 255 seconds]
enebo has joined #jruby
<GitHub55> [jruby] kares closed pull request #5037: align C ported memsearch code - need to handle array[length] properly (jruby-9.1...fix-2036-9.1) https://git.io/vAU9f
<GitHub3> [jruby] kares deleted fix-2036-9.1 at bc39a0a: https://git.io/vAsnF
<GitHub144> [jruby] kares pushed 1 new commit to jruby-9.1: https://git.io/vAsn5
<GitHub144> jruby/jruby-9.1 23f53d3 Karol Bucek: Merge pull request #5037 from jruby/fix-2036-9.1...
<GitHub114> [jruby] kares closed issue #5036: Scan ArrayIndexOutOfBoundsException Error https://git.io/vAUc9
<GitHub101> [jruby] kares pushed 2 new commits to master: https://git.io/vAscv
<GitHub101> jruby/master cb53364 kares: align BigDecimal 'bare' exponent no longer allowed + tidy-up tests
<GitHub101> jruby/master ad74415 kares: speed-up BigDecimal instantiation -> without Java regex matching
Puffball has quit [Remote host closed the connection]
Puffball has joined #jruby
Puffball has quit [Remote host closed the connection]
kares has joined #jruby
mkristian has joined #jruby
claudiuinberlin has joined #jruby
akp has joined #jruby
akp has quit [Ping timeout: 264 seconds]
drbobbeaty has joined #jruby
akp has joined #jruby
drbobbeaty has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…]
akp has quit [Remote host closed the connection]
akp has joined #jruby
akp has quit [Ping timeout: 240 seconds]
drbobbeaty has joined #jruby
shellac has joined #jruby
akp has joined #jruby
claudiuinberlin has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
akp has quit [Ping timeout: 256 seconds]
akp has joined #jruby
claudiuinberlin has joined #jruby
<GitHub105> [jruby] mkristian force-pushed jruby-readline-update from b8c9ca9 to d437392: https://git.io/vbOha
<GitHub105> jruby/jruby-readline-update d437392 Christian Meier: switch jruby-readline without shaded jline and without jar-dependencies
<enebo> lopex: thanks!
<enebo> kares: you see I looked at https://github.com/jruby/jruby/issues/4968
<enebo> kares: I can look more too (perhaps just a point at where I should look if so)
mkristian has quit [Quit: This computer has gone to sleep]
regedit has joined #jruby
xardion has quit [Remote host closed the connection]
xardion has joined #jruby
akp has quit [Remote host closed the connection]
akp has joined #jruby
<lopex> nirvdrum: which case slowed down the most from that benchmark ?
mkristian has joined #jruby
<nirvdrum> lopex: I'd have to re-run it, but I think the slow_blank? case was the most problematic.
mkristian has quit [Client Quit]
<nirvdrum> Both regressed, however.
mkristian has joined #jruby
<lopex> nirvdrum: for all the data ?
<lopex> i.e. strings
mkristian has quit [Client Quit]
<nirvdrum> lopex: I just deleted the cases that relied on the extension and then ran the benchmark with the remaining pure Ruby cases.
<lopex> nirvdrum: I'm going jmh I guess
<nirvdrum> I ran with joni 2.1.12 first, then 2.1.14e
<nirvdrum> Eh? In case it was lost, I'm running https://github.com/SamSaffron/fast_blank/blob/master/benchmark
<nirvdrum> And that uses benchmark-ips.
<lopex> I knwo
<headius> kares: have you looked any more at this proc binding JI leak thing?
<headius> I just updated...the IR reference is what's keeping it alive, but there's a separate bug why the associated proc+binding still survive after the call completes
<headius> I can't find a reference to it so far with vvm
brixen_ has quit [Quit: ZNC - http://znc.in]
<headius> brixen? in here?
<headius> kares enebo: I think I see it
<headius> the well I see something
<headius> -the
<headius> the interface impl class (generated) has a static RuntimeCache object it uses for invoking the associated object
<headius> so that anchors the proc and its binding to the class
<headius> because it was called once
<headius> this is a side effect of call site caching and singleton classes we can't really avoid in general
<headius> however
<headius> the class should go away and with it the cache
<headius> the class appears to be loaded into a rooted JRubyClassLoader
<headius> or at least a JRubyClassLoader that's held by a frame further up in the stack
<enebo> headius: I don't think that IR reference is keeping it alive though
<enebo> If I change func to proc { func; 1 }.call that 1GB I made for @b never goes away
<headius> but I confirmed it's keeping the JavaClass instance alive at least
<enebo> well it may be I am just saying that proc change should kill that root
<enebo> yeah for sure the instance is leaking
<headius> ok right, I don't see any references from the JavaClass instance to the proc
<headius> so the JavaClass instance "leaks" because of the IR tmp, but the big data leaks for separate reason
<headius> kares, enebo: I summarized problem and possible fixes
<lopex> jeeze this jmh takes forever
<headius> lopex: looks fine to me
<headius> I am not a JMH expert
<headius> ok, gotta run for lunch
<lopex> I dont see any regressions yet
<lopex> few percent faster for new joni version
<enebo> lopex: nirvdrum is running on graal?
shellac has quit [Quit: Leaving]
<lopex> enebo: I assume
<nirvdrum> enebo: I think I ran both with and without Graal. But I'll give it another look.
<nirvdrum> I am still running Java 8.
<nirvdrum> I'll try your benchmark, too. It would be more pronounced with longer strings, tool.
<nirvdrum> *too.
<enebo> lopex: wow RubyString.setEncoding() just changes the bytelists encoding regardless of sharing O_o
<lopex> enebo: hmm, is it a bug actually ?
<lopex> aaa
<lopex> bytelist
<enebo> lopex: perhaps someone removed modify()
<GitHub170> [jruby] nomadium opened pull request #5042: Deprecate Data class (ruby-2.5...deprecate-data-class) https://git.io/vAGDa
<lopex> enebo: but it wouldnt have to reallocate since is could switch to buffer share level
<lopex> and only create bytelist instanve
<lopex> *instance
<GitHub182> [jruby] nomadium opened pull request #5043: Module#attr, attr_accessor, attr_reader, attr_writer are now public (ruby-2.5...module-attr-methods-are-now-public) https://git.io/vAGyO
claudiuinberlin has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
subbu is now known as subbu|lunch
<headius> lopex: I'm not sure how well we're utilizing the two COW levels for strings at this point
<headius> generally I have always just called modify which I think does a full copy
drbobbeaty has quit [Read error: Connection reset by peer]
drbobbeaty has joined #jruby
<lopex> headius: yeah, it might be unecessary complexity
<lopex> headius: main point was ineffective calls like "a".strip
<headius> yeah I understand
<headius> really the buffer-sharing ought to live in ByteList itself and not be directly a part of RubyString logic
<headius> but there's a lot of things that should live in ByteList
<lopex> the levels are easy to remove though
bbrowning is now known as bbrowning_away
<GitHub164> [jruby-openssl] mhijazi1 opened issue #154: Wrong Serial/BN set when serial = 0 (0x0) https://git.io/vAGb3
<enebo> I think if bytelist has cow it shoudl be a subtype or not a main feature
<enebo> I know COW helps in cases but I just dislike it at this point :)
claudiuinberlin has joined #jruby
<headius> it will all be moot once Ruby 3.0 makes strings immutable
subbu|lunch is now known as subbu
bbrowning_away is now known as bbrowning
<GitHub12> [jruby] headius closed issue #5018: open3.rb broken in JRuby https://git.io/vNSL4
<enebo> although immutable strings makes COW more attactive :)
<GitHub114> [jruby] headius pushed 1 new commit to jruby-9.1: https://git.io/vAGhH
<GitHub114> jruby/jruby-9.1 f4df68b Charles Oliver Nutter: Bump size of core jar to accommodate updated libs.
akp has quit [Remote host closed the connection]
claudiuinberlin has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
<headius> enebo: there's no W
<headius> it's just shared buffers then
<headius> all our bugs come from the W
<headius> interestingly the JVM folks gave up on shared buffers altogether because it wasn't better than just making more of them
<headius> now they're reconsidering it seems
<lopex> java 7 update 5 afaik
<lopex> at least in string
<headius> yeah somewhere around there
<GitHub31> [jruby] headius pushed 1 new commit to master: https://git.io/vAGjX
<GitHub31> jruby/master ea6131a Charles Oliver Nutter: Merge branch 'jruby-9.1'
<headius> ok, that should resolve all unexpected failures on master too
<headius> ignoring these weird spurious timeouts that only seem to happen on Travis
claudiuinberlin has joined #jruby
damnski_ has joined #jruby
damnski has quit [Ping timeout: 240 seconds]
akp has joined #jruby
claudiuinberlin has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
akp has quit [Ping timeout: 268 seconds]
<lopex> nirvdrum: I have that regression
<lopex> pathological
<lopex> [x]+ agains long aaaa... for example
<headius> yay
<headius> try it against java.util.regex
<lopex> headius: 20x slower in new joni for "a" * 4000
<headius> woot
<headius> we need to get the TR benchmark CI set up somewhere for JRuby
<lopex> was looking in at wrong places
<headius> I just don't have funds to set up a VM
<lopex> something doesnt advance on opfail
<lopex> er even x+
<lopex> actually [x] is just x
claudiuinberlin has joined #jruby
<enebo> lopex: is it in newer mri vs older or was this more a factor of your recent engine changes?
<lopex> headius: some perf fuzzer would be cool
<headius> yeah MRI must not have this case?
<lopex> enebo: I wouldnt believe that
<enebo> we used to have some weird bench of regexps that ola made which represented things he found in Rails
<enebo> lopex: that == ?
<lopex> its the case :P
<enebo> what case?
<enebo> I had an OR in my sentence
<lopex> that it's onigmo case
<lopex> I'll look at it tomorrow
<enebo> ah so onigmo changes likely
<headius> ok
<lopex> no
<lopex> er, that was as not the case being it mri changes
<headius> lopex: you're coming to Krakow in May
<headius> just letting you know
<lopex> ok :P
<headius> heheh
<headius> enebo and I will both be there for GeeCON, we'd like to buy you dinner or something
akp has joined #jruby
<GitHub98> [jruby] enebo pushed 1 new commit to jruby-9.1: https://git.io/vAZTh
<GitHub98> jruby/jruby-9.1 f72c1b9 Thomas E. Enebo: Fix regressions after chr fixes. uptoCommon was changing our single byte...
<headius> rtyler: hey, do we have a setup where we could throw some of these bigger test suites and see if these timeouts are real or not?
<enebo> so that was much more complicated than expected
<headius> I'm fed up with travis and its sporadic failures
<headius> they look very much like resource limitations
akp has quit [Ping timeout: 260 seconds]
<lopex> now it really looks like onigmo
<lopex> even on mri 2.3
<headius> oh really?
<lopex> check x+ against some long failing string
<lopex> any failing quantifier
<GitHub110> [jruby] headius closed issue #5038: Bundler activates minitest from stdlib instead of installed gem after upgrading to RubyGems 2.7.5 https://git.io/vAtnX
claudiuinberlin has quit [Quit: Textual IRC Client: www.textualapp.com]
akp has joined #jruby
akp has quit [Ping timeout: 240 seconds]
bbrowning is now known as bbrowning_away
akp has joined #jruby
akp has quit [Ping timeout: 276 seconds]
drbobbeaty has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…]
Puffball has joined #jruby