ur5us has quit [Ping timeout: 244 seconds]
ur5us has joined #jruby
quadz has joined #jruby
zacts has joined #jruby
quadz_ has quit [Ping timeout: 240 seconds]
Freaky has quit [Quit: reboot]
Freaky has joined #jruby
zacts has quit [Quit: leaving]
joast has joined #jruby
ur5us has quit [Remote host closed the connection]
ur5us has joined #jruby
<kares[m]> okay I will merge. think we originally agreed on 9.2 (still need to add a test for the win regression) but 9.3 should do. going to open an issue for tracking remaining windiws failures.
<headius[m]> yeah I don't think we will do much more aggressive work on 9.2, which would certainly include Windows stuff
<headius[m]> I am trying to wrap up PRs for 9.3 so we can start talking abour release
<headius[m]> kares: I don't remember discussing 9.2 actually
<headius[m]> if your changes are pretty much just to support running the tests I don't have a preference
<headius[m]> the changes I rolled in had some fixes I might not be entirely comfortable landing on 9.2
<kares[m]> I am all for 9.3 originally things seemed less noisy and we wanted a win test I think ...
travis-ci has joined #jruby
<travis-ci> jruby/jruby (master:76233df by Charles Oliver Nutter): The build was broken. https://travis-ci.org/jruby/jruby/builds/728225790 [195 min 27 sec]
travis-ci has left #jruby [#jruby]
<headius[m]> blast that test
ur5us has quit [Ping timeout: 244 seconds]
<headius[m]> late night hackarama
Liothen has quit [Ping timeout: 260 seconds]
fidothe has quit [Ping timeout: 260 seconds]
lopex has quit [Ping timeout: 260 seconds]
lopex has joined #jruby
Liothen has joined #jruby
fidothe has joined #jruby
nirvdrum has joined #jruby
ur5us has joined #jruby
pedran[m] has quit [Quit: killed]
fzakaria1 has quit [Quit: killed]
MattPattersonGit has quit [Quit: killed]
patrice[m] has quit [Quit: killed]
TimGitter[m] has quit [Quit: killed]
CharlesOliverNut has quit [Quit: killed]
RomainManni-Buca has quit [Quit: killed]
KarolBucekGitter has quit [Quit: killed]
enebo[m] has quit [Quit: killed]
XavierNoriaGitte has quit [Quit: killed]
TimGitter[m]1 has quit [Quit: killed]
alfred[m]1 has quit [Quit: killed]
lopex[m] has quit [Quit: killed]
BlaneDabneyGitte has quit [Quit: killed]
joaocorreia[m] has quit [Quit: killed]
amit_suryavanshi has quit [Quit: killed]
natemccurdy[m] has quit [Quit: killed]
ChrisSeatonGitte has quit [Quit: killed]
MarcinMielyskiGi has quit [Quit: killed]
headius[m] has quit [Quit: killed]
kai[m] has quit [Quit: killed]
alexej[m] has quit [Quit: killed]
ahorek[m] has quit [Quit: killed]
an_old_dwarf[m] has quit [Quit: killed]
rdubya[m] has quit [Quit: killed]
OlleJonssonGitte has quit [Quit: killed]
csharpsteen[m] has quit [Quit: killed]
FlorianDoubletGi has quit [Quit: killed]
kares[m] has quit [Quit: killed]
JesseChavezGitte has quit [Quit: killed]
JulesIvanicGitte has quit [Quit: killed]
byteit101[m] has quit [Quit: killed]
UweKuboschGitter has quit [Quit: killed]
liamwhiteGitter[ has quit [Quit: killed]
mator[m] has quit [Quit: killed]
chrisseaton[m] has quit [Quit: killed]
travis-ci has joined #jruby
<travis-ci> jruby/jruby (master:e40431f by Karol Bucek): The build is still failing. https://travis-ci.org/jruby/jruby/builds/728269586 [193 min 7 sec]
travis-ci has left #jruby [#jruby]
mator[m] has joined #jruby
mator[m] has quit [Remote host closed the connection]
RomainManni-Buca has joined #jruby
ur5us has quit [Ping timeout: 244 seconds]
christian[m] has joined #jruby
pedran[m] has joined #jruby
shiri[m] has joined #jruby
alexej[m] has joined #jruby
raul[m] has joined #jruby
fzakaria1 has joined #jruby
kai[m] has joined #jruby
alfred[m] has joined #jruby
emil[m] has joined #jruby
patrice[m] has joined #jruby
walter[m] has joined #jruby
gisela[m] has joined #jruby
annette[m] has joined #jruby
jeremy[m]1 has joined #jruby
lopex[m] has joined #jruby
carla[m] has joined #jruby
taylorine[m] has joined #jruby
thomas[m]1 has joined #jruby
valentina[m] has joined #jruby
jean[m]2 has joined #jruby
FlorianDoubletGi has joined #jruby
kares[m] has joined #jruby
natemccurdy[m] has joined #jruby
enebo[m] has joined #jruby
rdubya[m] has joined #jruby
KarolBucekGitter has joined #jruby
byteit101[m] has joined #jruby
UweKuboschGitter has joined #jruby
MattPattersonGit has joined #jruby
mator[m] has joined #jruby
liamwhiteGitter[ has joined #jruby
headius[m] has joined #jruby
ChrisSeatonGitte has joined #jruby
JulesIvanicGitte has joined #jruby
BlaneDabneyGitte has joined #jruby
an_old_dwarf[m] has joined #jruby
XavierNoriaGitte has joined #jruby
JesseChavezGitte has joined #jruby
csharpsteen[m] has joined #jruby
TimGitter[m] has joined #jruby
amit_suryavanshi has joined #jruby
joaocorreia[m] has joined #jruby
MarcinMielyskiGi has joined #jruby
TimGitter[m]1 has joined #jruby
chrisseaton[m] has joined #jruby
CharlesOliverNut has joined #jruby
OlleJonssonGitte has joined #jruby
ahorek[m] has joined #jruby
gisela[m] has quit [Quit: Idle for 30+ days]
thomas[m]1 has quit [Quit: Idle for 30+ days]
jeremy[m]1 has quit [Quit: Idle for 30+ days]
emil[m] has quit [Quit: Idle for 30+ days]
annette[m] has quit [Quit: Idle for 30+ days]
zacts has joined #jruby
zacts has quit [Ping timeout: 256 seconds]
zacts has joined #jruby
zacts has quit [Quit: leaving]
subbu is now known as subbu|away
travis-ci has joined #jruby
<travis-ci> jruby/jruby (master:e122df3 by Charles Oliver Nutter): The build was fixed. https://travis-ci.org/jruby/jruby/builds/728393093 [203 min 59 sec]
travis-ci has left #jruby [#jruby]
rcrews[m] has joined #jruby
<headius[m]> woot
rcrews[m] has left #jruby ["User left"]
rcrews[m] has joined #jruby
<headius[m]> TCP_CORK support has been merged to master... I believe Puma still needs to be modified to enable it on JRuby, but that should fix the bogus slow requests on tiny benchmarks
<travis-ci> jruby/jruby (master:d04c818 by Charles Oliver Nutter): The build was broken. https://travis-ci.org/jruby/jruby/builds/728411668 [201 min 32 sec]
travis-ci has left #jruby [#jruby]
travis-ci has joined #jruby
subbu|away is now known as subbu
<ahorek[m]> let's split TCP_CORK and TCP_INFO, those features aren't related, I'll take a look https://github.com/jruby/jruby/issues/6399
<headius[m]> ahorek: yeah I agree... I can't find anything that would indicate those need to go together
<headius[m]> I have shifted gears to macos aarch64 support for a bit but I'm around
<headius[m]> wow, and I thought gem doco generation was slow before, it's impressively slow without a JIT
<headius[m]> Done installing documentation for bundler after 123 seconds
ur5us has joined #jruby
<ahorek[m]> looking at the TCP_INFO issue now.... my changes shoudn't break TCP_CORK, it raises Errno::ENOPROTOOPT which is rescued here https://github.com/puma/puma/blob/master/lib/puma/server.rb#L141 right? so it's simply ignored
<headius[m]> but your "supported" check requires TCP_INFO
<ahorek[m]> TCP_INFO constant is defined since https://github.com/jnr/jnr-constants/pull/70/files
<headius[m]> it is but it's not defined in JRuby yet
<ahorek[m]> aha
<headius[m]> and if we define it then we need to support it
<headius[m]> but I think the TCP_CORK logic in puma could be used with or without TCP_INFO
<headius[m]> macos_aarch64
<headius[m]> oops
<ahorek[m]> it is
<headius[m]> oh hmm
<headius[m]> I got an error on my TCP_CORK branch... I merged master but perhaps it was still out of date
<headius[m]> ok
<headius[m]> this is the sort of situation I was referring to when I said I had some concerns about binding everything... it's not a big deal, but this particular flag has a lot of baggage
<ahorek[m]> there's one more issue, unlike CRuby we do define fake constants on platforms that don't support them. So a feature check like this https://github.com/puma/puma/pull/2349/files doesn't really work on JRuby
<headius[m]> right, the automatic binding should be enhanced to check isDefined on the constants
<headius[m]> I added isDefined a couple years back for this purpose
<headius[m]> $ jruby -e 'p Java::jnr.constants.platform.TCP::TCP_CORK.defined?'
<headius[m]> false
<headius[m]> on macos, for example
<headius[m]> hmm
<headius[m]> yeah it's not specific to jnr constants
<headius[m]> the jnr enums all implement jnr.constants.Constant
<headius[m]> I guess we need to add a loadConstantSet that knows how to handle JNR
ur5us has quit [Quit: Leaving]
<headius[m]> MRI doesn't define TCP_CORK either
<headius[m]> not sure why, they clearly define other constants that aren't available on all platforms
travis-ci has joined #jruby
<travis-ci> jruby/jruby (master:e41c99f by Charles Oliver Nutter): The build was fixed. https://travis-ci.org/jruby/jruby/builds/728447563 [202 min 19 sec]
travis-ci has left #jruby [#jruby]
nirvdrum has quit [Ping timeout: 240 seconds]
<ahorek[m]> on Linux?
<ahorek[m]> let's see what happens https://github.com/jruby/jruby/pull/6401
<headius[m]> hmm maybe it does
<headius[m]> I see references to it in mkconstants.rb and some tests but nothing in C code
<headius[m]> yeah ok so it is there
<headius[m]> nm
<headius[m]> vagrant@vagrant:~$ ruby -rsocket -e 'p Socket::TCP_CORK'
<headius[m]> 3
<headius[m]> oh so close to running rails on mac/arm64
<headius[m]> sqlite3 requires native code we can't load
<headius[m]> I guess I can merge in this branch
annette[m] has joined #jruby